Improved select case parsing#14
Merged
verhas merged 1 commit intoverhas:masterfrom Jan 2, 2020
Merged
Conversation
verhas
requested changes
Dec 31, 2019
Owner
verhas
left a comment
verhas
left a comment
There was a problem hiding this comment.
I am not absolutely sure that the single one new test covers all new code. I have not checked it. If it does, I accept that but my gut feeling is that there are more cases that need a bit more BASIC test programs to cover the extra checks.
The fact that these extra cases are checked and do not just get silently ignored is great and also the style of the implementation is absolutely in-line with the philosophy and style of the project. Some formatting, minimal English grammar modification in error messages is needed and I will be happy to merge this change into the project. Thanks.
…atements after 'select case <expr>'
PetrPytelka
force-pushed
the
improved_select_case_parsing
branch
from
832de27 to
bf69d35
Compare
Contributor
Author
|
Thank you for your review. I added one more test and did all changes according your recommendations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved select case syntax parser.
Check if there are only 'case' statements after 'select case '