ci: enforce test failures and update Node.js matrix to 20/22#1
Merged
kiyeonjeon21 merged 1 commit intomainfrom Feb 24, 2026
Merged
ci: enforce test failures and update Node.js matrix to 20/22#1kiyeonjeon21 merged 1 commit intomainfrom
kiyeonjeon21 merged 1 commit intomainfrom
Conversation
- Remove continue-on-error from Test step so failing tests block PRs - Update Node.js matrix from [18, 20] to [20, 22] (Node 18 reached EOL) - Rename job from 'build' to 'build-and-test' to reflect what it does - Keep continue-on-error on Lint (lint warnings should not block PRs) - Update typecheck job to use Node 22 Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kiyeonjeon21
added a commit
that referenced
this pull request
Mar 7, 2026
…md, fix landing page - Implement Grok video CLI (was placeholder) in generate.ts and agent tool - Change default video provider from Kling to Grok Imagine (native audio, #2 Elo) - Add Audio column to MODELS.md video table (Yes/No per model) - Add Kling 3.0 Omni (#1 Elo) and update Runway gen4_turbo → gen4.5 - Fix all 12 "vibe ai *" → proper command syntax in landing page - Update version badge, tool/command counts across docs and landing page Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: truefrom the Test step. Previously, test failures were silently ignored and PRs could merge even with broken tests.build→build-and-testto accurately reflect what it does.continue-on-error: truekept on Lint since the codebase has some pre-existing lint warnings that are not critical.Test plan
Made with Cursor