feat(cli)!: complete envelope migration — scene/timeline/pipeline/analyze (Issue #33 — 2c-sweep-3)

[kiyeonjeon21]

Summary

Final sweep of the `--json` envelope migration. After this PR, every CLI command's `--json` output uses the canonical envelope established in #194. The old `outputResult()` helper is now unused outside `output.ts` itself.

Files (8)

File	Sites	Quirk
`scene.ts`	16	3 failure-path `{...result}` spreads (compose-prompts, render, build) preserved with `process.exitCode = 1` from #193
`timeline.ts`	9	dry-run only; success-path JSON deferred to separate "2c-coverage" PR
`analyze.ts`	3	dropped local `--fields` filter (now handled by helper)
`pipeline.ts`	2	standard
`ai-highlights.ts`	2	standard
`ai-script-pipeline-cli.ts`	1	standard
`ai-review.ts`	1	standard
`output.ts`	helper change — see below

Helper change: `--fields` now filters data keys

`outputSuccess()` now applies `--fields` filtering to keys inside `data`, leaving envelope meta (`command`, `elapsedMs`, `costUsd`, `warnings`, `dryRun`) intact. Matches the documented `--fields response,model` UX from `analyze.*` and avoids agents writing `--fields data` to keep the payload.

```

Old (envelope-level filter):

$ vibe analyze video x.mp4 "..." --fields response
{} # envelope had no top-level 'response' key

New (data-level filter):

$ vibe analyze video x.mp4 "..." --fields response
{ "command": "analyze video", "elapsedMs": ..., "costUsd": ..., "warnings": [], "data": { "response": "..." } }
```

Scene failure-path pattern (Quirk 1)

3 sites in `scene.ts` emit a result-shape JSON to stdout before setting `exitCode=1`. Metadata (which beat failed, which violation, etc.) is useful for agents diagnosing:

```ts
if (!result.success) {
if (isJsonMode()) {
outputSuccess({
command: "scene render",
startedAt,
data: { ...result }, // success: false, error, metadata
});
process.exitCode = 1;
return;
}
exitWithError(generalError(result.error ?? "Render failed"));
}
```

Function is still named `outputSuccess` even when emitting failure metadata — exit code 1 is the failure signal, `data.success: false` is metadata.

Smoke tests (verified locally)

```
$ vibe scene styles --json
{ "command": "scene styles", "costUsd": 0, "warnings": [], "data": { "count": 8, "styles": [...] } }

$ vibe timeline add-source proj.json /tmp/x.mp4 --dry-run --json
{ "command": "timeline add-source", "dryRun": true, "costUsd": 0, "warnings": [], "data": { "params": {...} } }
```

What 2c does NOT cover (deferred to 2c-coverage PR)

The audit (#192) flagged commands that lack `--json` entirely. This PR series only migrated commands that already emitted JSON. Coverage gaps still open:

• `timeline.*` success paths emit no JSON (10 commands)
• `scene render` / `scene build` / `scene add` partial `--json` (some paths still console.log only)
• `export video` has no `--json` mode
• `doctor` works but could surface more

These will go in a separate "2c-coverage" PR after the envelope is stable.

Migration summary across the whole 2c series

PR	Commands migrated	Sites
#194 (canary)	`generate image`	5
#195 (sweep-1)	11 `generate.*`	27
#196 (sweep-2)	edit/audio/detect/batch/project/export/run/init/etc. (13 files)	~55
#this (sweep-3)	scene/timeline/pipeline/analyze (8 files)	34
Total	~33 files	~121 sites

Test plan

• `pnpm -r exec tsc --noEmit` — 0 errors (full-repo, matches CI)
• `pnpm lint` — 0 errors (8 pre-existing warnings)
• `pnpm -F @vibeframe/cli exec vitest run` — 700 passed, 9 skipped, 0 failed
• `grep "outputResult" packages/cli/src/commands/` — 0 hits (only `output.ts` still has the helper definition)
• Smoke tests on scene styles + timeline add-source dry-run

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
vibeframe	Ready	Preview, Comment	Apr 28, 2026 3:34pm