-
Notifications
You must be signed in to change notification settings - Fork 430
Expand build compatibility on GCC and Clang for Ubuntu 22.04 #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ang-13, and clang-14
|
@vaughnbetz @hzeller I managed to reproduce the error using gcc-12 on my local machine. Also you can see the error on CI machine. As you predicted, it is indeed related to the bool type of swap. I am working on it now. |
|
Following the suggestions in https://stackoverflow.com/questions/58660207/why-doesnt-stdswap-work-on-vectorbool-elements-under-clang-win I am using: Now the problem is resolved. Let me know if you have any preference. |
…ting/vtr-verilog-to-routing into xt_ci_build_compatibility
…-to-routing into xt_ci_build_compatibility
|
Great, thanks @tangxifan . For some reason the template function matching must not have been finding the bool specialization until you put in the more explicit request. I think this is now ready to be merged ... let me know if you want me to merge it now. |
Hi @vaughnbetz Before merging, I just need to fix a minor issue on clang-11 which is found on the CI machine. It should be quick. |
|
@vaughnbetz All the build compatibility tests passed. If you see any needs on updating documentation, just let me know. This PR is ready to merge. |
|
Thanks @tangxifan . I've updated the documentation that I think needs updating. If I missed anything that you see please update it. |
Description
Due to the compiler version upgrades in Ubuntu 22.04, build compatibility should be restored.
In this PR, the build compatibility is expanded to
Related Issue
To address issue #2270
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: