-
Notifications
You must be signed in to change notification settings - Fork 428
Extract channel width from RR graph #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_factors_for_place_cost_()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Soheil!
QoR differs from master because the computed channel width for the top and right channels at the periphery of the device is zero, while on master, As discussed with @amin1377, we believe the current implementation is more accurate, since those channels actually contain no tracks. I’ll collect QoR results for this branch and update the golden results if no significant degradation is observed. Currently, bounding box computation uses the tile location of pins. It would be more accurate to use the location of the channel the pin connects to. This would require subtracting one from the x/y coordinate of pins located on the left or bottom sides of a tile. |
Should do a QoR run on this to ensure all is well. Suggest: |
For a few small circuits, routing succeeds at min_W but fails at a relaxed W. |
Weird, but can happen. Could change them to run at a fixed channel width if you're pretty sure all is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I changed the seed to resolve this. |
No QoR difference in titan_quick_qor was seen. |
Nightly test 1, which was the only failing nightly test now passes. @amin1377 If you don't have further comments, could you please approve this PR? |
This PR computes channel widths directly from the RR graph. These computed values now replace t_chan_width usages outside of the RR graph generation.