[Pack] Removed Pb Pin Scratchpad #3333
Merged
+56
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found another use of scratchpad memory in the pb type graph data structure which was only used in one place. Removed it and replaced it with proper data structures being passed around.
github-actions
bot
added
VPR
Contributor
AmirhosseinPoolad
left a comment
AmirhosseinPoolad
left a comment
There was a problem hiding this comment.
Thanks for the PR Alex. Looks good, but I think you should add comments explaining the purpose of seen_pins and pin_marker.
Contributor
Author
|
@AmirhosseinPoolad Unfortunately, I have no clue what this code is even trying to do; but I added comments explaining these variables the best that I could. |
Contributor
|
Lol. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found another use of scratchpad memory in the pb type graph data structure which was only used in one place.
Removed it and replaced it with proper data structures being passed around.