Skip to content

Conversation

@AlexandreSinger
Copy link
Contributor

The CAD types header file does not belong in libarchfpga since it was only really used in the prepacker of VPR. It makes several references to the pb_graph structure which I would ultimately like to move into VPR entirely.

This change only moves the declarations of types into VPR. No changes on functionality was made.

The CAD types header file does not belong in libarchfpga since it was
only really used in the prepacker of VPR. It makes several references to
the pb_graph structure which I would ultimately like to move into VPR
entirely.
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code labels Nov 14, 2025
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmirhosseinPoolad AmirhosseinPoolad merged commit aec8907 into master Nov 14, 2025
30 checks passed
@AmirhosseinPoolad AmirhosseinPoolad deleted the feature-remove-cad-types branch November 14, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants