Merged
Conversation
jmillan
reviewed
Nov 20, 2020
Member
|
Great, Just a cosmetic change requested. |
We MUST take the ownership of |desc| in callback 'CreateSessionDescriptionObserver::OnSuccess'.
Contributor
Author
|
I have pushed one more commit to fix another memory leak. See the comment of CreateSessionDescriptionObserver::OnSuccess in /path/to/webrtc/src/api/jsep.h, the the ownership of the |desc| is transferred by the callback, so we MUST take the ownership. |
Co-authored-by: José Luis Millán <jmillan@aliax.net>
jmillan
reviewed
Nov 20, 2020
jmillan
approved these changes
Nov 20, 2020
Member
|
Thanks @ploverlake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The std::vector won’t delete the objects that are pointed to.