Update libsdptransform to 1.2.10; use cmake's FetchContent; cleanup deps#171
Merged
jmillan merged 4 commits intoversatica:v3from Dec 18, 2023
Merged
Conversation
jmillan
reviewed
Dec 15, 2023
Member
jmillan
left a comment
jmillan
left a comment
There was a problem hiding this comment.
Seems like a good idea fetching Catch2 too, for consistency.
Contributor
Author
|
Also added fetching of Catch2. |
Contributor
Author
|
As a side note, libsdptransform is in ibc's github space (https://github.com/ibc/libsdptransform.git). Maybe he could consider moving it to versatica. |
tdrz
changed the title
jmillan
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having issues compiling libmediasoupclient on ubuntu 22.04 and it turns out that updating libsdptransform to latest available (1.2.10) solved it.
I also used cmake's FetchContent instead of using the deps/libsdptransform folder. Maybe something to use also for catch2?