SeqManager: Properly remove dropped entries #1054
Conversation
Fixes #1037. Keep dropped entries clean by removing those higher than this->maxInput.
|
@vpalmisano I've tested this with the STR that I provided and which is failing in V3. Can you give it a try? |
|
I must confess that I don't understand whether the PR description describes an issue or the working solution. |
After 1h test I got no big loss events, so probably we could say that this was fixed :) |
|
Test failing.. I was filtering by [SeqManager] in local..., checking.. |
A dropped input is part of the same sequence, hence set it to 'maxInput' if the dropped value is higher than the current 'maxInput'. Without this consideration we would be wrongly erasing dropped inputs that are legitimally just the maximum input of the sequence stream.
|
There are some changes in the tests generated out of the Fuzzer output. I've reviewed them and they make sense. |
Which has a linear complexity. Use lower_bound which has logarithmic complexity.
|
@ibc, no hurries. Reassigning for review since I've done some performance improvements. IMHO 1: No need to consider dropped inputs if |
I didn't try honestly. let me try it tomorrow morning. |
We are safe. |
Fixes #1037.
Keep dropped entries clean by removing those higher than this->maxInput.
This cleans both the
Insert()andClearDropped()methods. We remove those dropped entries which are from a previous sequence iteration.STR with mediasoup-demo with single host:
Tab 1: roomId=loss&forceVP9=true&consume=false
Tab 2: roomId=loss&forceVP9=true&produce=false
In tab 2, select the preferred layers (0,0). Many packets are discarded by the codec
It takes few minutes until the seq number wraps ups. Wait for 1 or two wraps up. Vide in Tab 2 should be OK.