RTCP CompoundPacket: Use a single DLRR block to hold all ssrc infos
#1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1211 ### Details - Previously, our `CompoundPacket` has a XR packet with many DLRR blocks, each one with a single ssrc info sub-block. - Now our `CompoundPacket` has a XR pacjet with a single DLRR block with many ssrc info sub-blocks. - Both approaches are spec compliant **BUT** libwebrtc thinks it makes no sense to have multiple blocks of the same type in an XR packet: https://codereview.webrtc.org/2378113002 - Thanks @ybybwdwd for reporting the issue and for the references. ### TODO - Same should be done for other blocks. This must be verified.
This was referenced Nov 22, 2023
Member
Author
|
I've created a separate issue to handle the rest of extended reports that may need some changes: |
jmillan
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1211
Details
CompoundPackethas a XR packet with many DLRR blocks, each one with a single ssrc info sub-block.CompoundPackethas a XR pacjet with a single DLRR block with many ssrc info sub-blocks.TODO