VP8 keyframe detect fix for non-extended payloads #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
Sep 23, 2025
Member
ibc
left a comment
ibc
left a comment
There was a problem hiding this comment.
A super cosmetic change request. Other than that, let's us take a look to it, please, and thanks a lot.
Member
|
Please add this in diff --git a/CHANGELOG.md b/CHANGELOG.md
index 60384b8fa..031a96e2e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
### NEXT
- CI: Remove `macos-13` hosts.
+- VP8: Fix keyframe detection if "extended" bit is not set ([PR #1612](https://github.com/versatica/mediasoup/pull/1612), credits to @nifigase).
### 3.19.2 |
Co-authored-by: Iñaki Baz Castillo <ibc@aliax.net>
Co-authored-by: Iñaki Baz Castillo <ibc@aliax.net>
Co-authored-by: Iñaki Baz Castillo <ibc@aliax.net>
Member
|
Let's merge, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced the following issue with modern chrome (139.0.7258.127) sending simulcast video in VP8.
Mediasoup fails to detect keyframes: VP8 payload parser ignores whole payload if "extended" bit is not set https://datatracker.ietf.org/doc/html/rfc7741#section-4.2
Chrome may send packets with no extended control bits. But even in this case "payload header" with inverse keyframe flag is present in packet, according to RFC: https://datatracker.ietf.org/doc/html/rfc7741#section-4.3