Skip to content

Conversation

@jmillan
Copy link
Member

@jmillan jmillan commented Nov 11, 2020

  • DataConsumer: make 'setBufferedAmountLowThreshold' trigger 'bufferedamountlow'
    if the buffered amount data is less or same than the given threshold.

  • SctpAssociation: Increase buffered amount data before sending it in
    order to avoid inconsistencies if 'onSendSctpData' fires while 'usrsctp_senv'
    is being executed. Be conservative.

- DataConsumer: make 'setBufferedAmountLowThreshold' trigger 'bufferedamountlow'
    if the buffered amount data is less or same than the given threshold.
- SctpAssociation: Increase buffered amount data before sending it in
  order to avoid inconsistencies if 'onSendSctpData' fires while 'usrsctp_senv'
  is being executed. Be conservative.
@jmillan jmillan requested a review from ibc November 11, 2020 13:56
@jmillan
Copy link
Member Author

jmillan commented Nov 11, 2020

We don't have full control on the real buffered data in usrsctp. With this changes we can subscribe to 'bufferedamountlow' event and set the buffered amount low threshold and we will be sure that:

  • the event will fire if there is less or same buffered buffer as indicated.
  • otherwise the event will fire as soon as there is less or same buffered buffer as indicated.

@jmillan jmillan merged commit dcb9c1b into v3 Nov 11, 2020
@jmillan jmillan deleted the sctp-fix branch November 11, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants