changed deprecated flag for updated version#651
Merged
aooohan merged 1 commit intoversion-fox:mainfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the autogenerated Nushell activation script to avoid a deprecation warning by switching from the deprecated get --ignore-errors (-i) flag to the renamed get --optional (-o) flag.
Changes:
- Update Nushell
hooks.pre_promptconfig lookup to useget -oinstead ofget -i.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
43
to
45
| $env.config = ($env.config | upsert hooks.pre_prompt { | ||
| let currentValue = ($env.config | get -i hooks.pre_prompt) | ||
| let currentValue = ($env.config | get -o hooks.pre_prompt) | ||
| if $currentValue == null { |
There was a problem hiding this comment.
The activation template now uses get -o here, but internal/shell/nushell_test.go (TestNushellActivateWithPidCheck) currently asserts that get -i is present and that get -o is absent. This will cause the existing unit test suite to fail once this change lands; update the test expectations (and its comment) to match the new flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Current autogenerated config for nushell produces this warning on load:
Changes
Updated config generation script to use the appropriate flag