This repository was archived by the owner on Jun 14, 2018. It is now read-only.
Merged
Conversation
Member
Author
|
After 055a6a1, some features are missing that should return back:
The rest can be left out for the moment:
|
…change that drops some features but in return, makes the whole project structure a lot simpler. Details:
- Multiple Gulp files in the `config` folder were merged to the standard, single `gulpfile.js`
- Dtto for webpack - there's now a standard `webpack.config.js` and one can actually run `webpack` from the site root which was not working previously
- Generally, no weird concepts are used in the gulpfile anymore (e.g., prefixing Gulp plugins and even non-Gulp functions with `$.` was removed)
- `.env.example` cleaned up
- Better documentation for some Gulp tasks
- Removed several features for now. Most of them will return in the future, in a cleaner way. Those were:
- TS linting
- Client-side source files watching using webpack dev server. Watching server-side TS files is still there and, also, MD and JS files are watched and will reload the Node server / browsers via Browsersync.
- Distinguishing between DEV and PROD environment. It was done a bit chaotically, will be re-implemented once we know for sure where we need this distinction and why.
- Single `bundle.js` is used instead of `app.js` plus `app.css`. This change was done to keep things simple (and commit finally :) ) but the previous approach was arguably better, for example, there are now temporary rendering glitches until the CSS is fully loaded via JS. We'll return to the previous approach soon.
- Updated README to be simpler and guide the user to the main workflow of running the site and editing Markdown files.
…ering issues when loading Bootstrap-styled images etc.
borekb
force-pushed
the
67-simplify-gulp-etc
branch
from
6b12f5a to
5f61e74
Compare
…just using gulp.watch() and quite slow. webpack dev server would be useful in the future.
This was referenced Apr 1, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #67.
The goal of this PR is to make the system of Gulpfiles, webpack config files etc. simpler.