Skip to content

Fixes from CODEX, from dev branch#51

Merged
vertesy merged 10 commits intomainfrom
dev
Aug 12, 2025
Merged

Fixes from CODEX, from dev branch#51
vertesy merged 10 commits intomainfrom
dev

Conversation

@vertesy
Copy link
Owner

@vertesy vertesy commented Aug 12, 2025

No description provided.

@vertesy vertesy requested a review from Copilot August 12, 2025 14:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request contains fixes from CODEX/dev branch focusing on correcting spelling, grammar, and documentation inconsistencies across R documentation files. The changes primarily address typos in function parameter descriptions, improve consistency in capitalization and punctuation, and standardize terminology.

  • Corrected spelling errors throughout documentation (e.g., "tow-column" → "two-column", "Covert" → "Convert")
  • Standardized capitalization and punctuation in parameter descriptions
  • Fixed inconsistent terminology and formatting in function documentation

Reviewed Changes

Copilot reviewed 21 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
man/*.Rd Fixed spelling errors, capitalization, and punctuation in function parameter descriptions
R/ggExpress.R Corrected documentation strings and improved code with better validation and namespace usage
README.md Fixed typos and updated function descriptions to match corrected documentation
Examples/Testing.ggpubr.R Corrected spelling errors in comments
Development/*.R Updated function names and descriptions to fix spelling errors
CITATION.cff Removed duplicate "and" in title
AGENTS.md New file providing guidance for AI agents working with the codebase

filename
} else {
FixPlotName(plotname, fix, suffix, flag.nameiftrue(logY), "strip", ext)
FixPlotName(plotname, suffix, fix, flag.nameiftrue(logY), ext)
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter order appears to be incorrect. Based on the function call pattern in other functions, it should likely be FixPlotName(plotname, fix, suffix, flag.nameiftrue(logY), "strip", ext) to match the expected parameter order.

Suggested change
FixPlotName(plotname, suffix, fix, flag.nameiftrue(logY), ext)
FixPlotName(plotname, fix, suffix, flag.nameiftrue(logY), "strip", ext)

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version eliminates a double "strip" annotation, as far as i understood.

@vertesy vertesy merged commit 22f3500 into main Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants