Skip to content

Conversation

@vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Feb 4, 2026

  • Move functions related to the spawning and forkserver process pool from synapse.lib.coro into synapse.lib.process and synapse.lib.processpool. This allows coro module to be solely asyncio task / coroutine support; and minimizes the need to import the processpool module ( and cause implicit side effects ) to only the modules which need to utilize the pool.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 97.56098% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.72%. Comparing base (a94c1f4) to head (9bdb168).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
synapse/lib/processpool.py 93.87% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4729   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         296      298    +2     
  Lines       62157    62168   +11     
=======================================
+ Hits        60742    60753   +11     
  Misses       1415     1415           
Flag Coverage Δ
linux 97.64% <97.56%> (-0.01%) ⬇️
linux_replay 93.39% <97.56%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MichaelSquires
MichaelSquires previously approved these changes Feb 4, 2026
@vEpiphyte vEpiphyte marked this pull request as ready for review February 4, 2026 20:04
@vEpiphyte vEpiphyte marked this pull request as draft February 4, 2026 20:09
@vEpiphyte vEpiphyte marked this pull request as draft February 4, 2026 20:09
…just need spawn() do not need pool functions.
@vEpiphyte vEpiphyte marked this pull request as ready for review February 4, 2026 21:12
@vEpiphyte vEpiphyte added this to the v2.23x.x milestone Feb 5, 2026
@vEpiphyte vEpiphyte merged commit 3594350 into master Feb 5, 2026
6 checks passed
@vEpiphyte vEpiphyte deleted the dev_split_coro_pool branch February 11, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants