Skip to content

SYN-7334: resolve view bug in ddefs and implement a storage migration#4771

Merged
invisig0th merged 9 commits intomasterfrom
SYN-7334
Mar 10, 2026
Merged

SYN-7334: resolve view bug in ddefs and implement a storage migration#4771
invisig0th merged 9 commits intomasterfrom
SYN-7334

Conversation

@invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (d94ccac) to head (05557c4).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4771      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files         298      298              
  Lines       62363    62383      +20     
==========================================
+ Hits        60952    60968      +16     
- Misses       1411     1415       +4     
Flag Coverage Δ
linux 97.65% <100.00%> (-0.03%) ⬇️
linux_replay 93.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be validating the ddef before adding it.

I also noticed a few comments from @vEpiphyte in the ticket that don't seem to be addressed: https://vertexproject.atlassian.net/browse/SYN-7334?focusedCommentId=18032

@invisig0th
Copy link
Contributor Author

I think we should be validating the ddef before adding it.

Added validation 👍

I also noticed a few comments from @vEpiphyte in the ticket that don't seem to be addressed: https://vertexproject.atlassian.net/browse/SYN-7334?focusedCommentId=18032

The comments represent work that seems way outside the scope for this ticket. We should probably create another ticket, i suspect it will be a larger LOE than this entire Story captured originally...

MichaelSquires
MichaelSquires previously approved these changes Mar 9, 2026
MichaelSquires
MichaelSquires previously approved these changes Mar 10, 2026
Co-authored-by: Cisphyx <cisphyx@vertex.link>
@invisig0th invisig0th requested a review from Cisphyx March 10, 2026 14:42
@invisig0th invisig0th merged commit 9cb2cab into master Mar 10, 2026
6 checks passed
@invisig0th invisig0th deleted the SYN-7334 branch March 10, 2026 14:57
@vEpiphyte vEpiphyte added the bug label Mar 11, 2026
@vEpiphyte vEpiphyte added this to the v2.23x.x milestone Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants