SYN-7334: resolve view bug in ddefs and implement a storage migration#4771
SYN-7334: resolve view bug in ddefs and implement a storage migration#4771invisig0th merged 9 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4771 +/- ##
==========================================
- Coverage 97.73% 97.73% -0.01%
==========================================
Files 298 298
Lines 62363 62383 +20
==========================================
+ Hits 60952 60968 +16
- Misses 1411 1415 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelSquires
left a comment
There was a problem hiding this comment.
I think we should be validating the ddef before adding it.
I also noticed a few comments from @vEpiphyte in the ticket that don't seem to be addressed: https://vertexproject.atlassian.net/browse/SYN-7334?focusedCommentId=18032
Added validation 👍
The comments represent work that seems way outside the scope for this ticket. We should probably create another ticket, i suspect it will be a larger LOE than this entire Story captured originally... |
Co-authored-by: Cisphyx <cisphyx@vertex.link>
No description provided.