SYN-8508: allow diff --tag to accept list variables#4783
Merged
invisig0th merged 7 commits intomasterfrom Mar 11, 2026
Merged
Conversation
Updated the diff --tag Storm command to accept list variables in addition to individual tag arguments, making it easier to programmatically diff a set of tags. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace str() cast with an isinstance check that raises BadArg if a non-string value is passed to diff --tag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add storm:dmon:add and storm:dmon:del events fired from the nexus handlers to allow tests to properly await dmon registration, eliminating a race condition in test_storm_dmon_query_state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
invisig0th
commented
Mar 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4783 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 298 298
Lines 62388 62400 +12
=======================================
+ Hits 60975 60987 +12
Misses 1413 1413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelSquires
previously approved these changes
Mar 11, 2026
Cisphyx
reviewed
Mar 11, 2026
Cisphyx
reviewed
Mar 11, 2026
Contributor
Author
It's currently targeted at master because it seemed relatively straight forward. Are you worried about the merge to 3x? |
Co-authored-by: Cisphyx <cisphyx@vertex.link>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Yeah, mostly just tests but I think these line up fine and will only need to be tweaked for polyprops |
Cisphyx
approved these changes
Mar 11, 2026
mikemoritz
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diff --tagStorm command to accept list variables (e.g.,$tags=(foo, bar) diff --tag $tags) in addition to individual tag argumentsdiff --tag foo $tags bar)Test plan
test_storm_diff_mergetests pass--tag🤖 Generated with Claude Code