Skip to content

Remove support for nested virtual properties #4885

Merged
Cisphyx merged 9 commits intosynapse-3xxfrom
flatten-virts
Apr 14, 2026
Merged

Remove support for nested virtual properties #4885
Cisphyx merged 9 commits intosynapse-3xxfrom
flatten-virts

Conversation

@Cisphyx
Copy link
Copy Markdown
Contributor

@Cisphyx Cisphyx commented Apr 13, 2026

A large part of this is naming cleanup (adjusting virts -> virt)

@Cisphyx Cisphyx added this to the v3.0.0 milestone Apr 13, 2026
@Cisphyx Cisphyx marked this pull request as draft April 13, 2026 14:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 97.14286% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.46%. Comparing base (3a8ef8c) to head (8e686ac).
⚠️ Report is 1 commits behind head on synapse-3xx.

Files with missing lines Patch % Lines
synapse/lib/ast.py 94.35% 11 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           synapse-3xx    #4885      +/-   ##
===============================================
+ Coverage        96.34%   96.46%   +0.11%     
===============================================
  Files              259      259              
  Lines            63173    63060     -113     
===============================================
- Hits             60864    60830      -34     
+ Misses            2309     2230      -79     
Flag Coverage Δ
linux 96.46% <97.14%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cisphyx Cisphyx marked this pull request as ready for review April 14, 2026 03:14
@Cisphyx Cisphyx merged commit acde827 into synapse-3xx Apr 14, 2026
5 checks passed
@Cisphyx Cisphyx deleted the flatten-virts branch April 14, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant