Skip to content

Cull dead array lift code#4887

Merged
Cisphyx merged 1 commit intosynapse-3xxfrom
remove-dead-arraylifts
Apr 13, 2026
Merged

Cull dead array lift code#4887
Cisphyx merged 1 commit intosynapse-3xxfrom
remove-dead-arraylifts

Conversation

@Cisphyx
Copy link
Copy Markdown
Contributor

@Cisphyx Cisphyx commented Apr 13, 2026

No description provided.

@Cisphyx Cisphyx added this to the v3.0.0 milestone Apr 13, 2026
Comment thread synapse/lib/view.py
return

else:
for cmprval in cmprvals:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrays are always poly now, this is just the elif prop.type.arraytype.ispoly: branch but git isn't displaying it nicely.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (c3aaad9) to head (6f6e191).
⚠️ Report is 1 commits behind head on synapse-3xx.

Additional details and impacted files
@@               Coverage Diff               @@
##           synapse-3xx    #4887      +/-   ##
===============================================
+ Coverage        96.23%   96.34%   +0.10%     
===============================================
  Files              259      259              
  Lines            63244    63173      -71     
===============================================
- Hits             60866    60865       -1     
+ Misses            2378     2308      -70     
Flag Coverage Δ
linux 96.34% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cisphyx Cisphyx merged commit 3a8ef8c into synapse-3xx Apr 13, 2026
5 checks passed
@Cisphyx Cisphyx deleted the remove-dead-arraylifts branch April 13, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant