Skip to content

Add MITRE ATT&CK ID forms to polyprop definitions#4904

Merged
mikemoritz merged 3 commits intosynapse-3xxfrom
20260420-mitre-id-forms
Apr 20, 2026
Merged

Add MITRE ATT&CK ID forms to polyprop definitions#4904
mikemoritz merged 3 commits intosynapse-3xxfrom
20260420-mitre-id-forms

Conversation

@mikemoritz
Copy link
Copy Markdown
Contributor

Summary

  • Define named poly types (risk:threat:id, entity:campaign:id, risk:tool:software:id, meta:technique:id, risk:mitigation:id, plan:phase:id) that include the corresponding MITRE ATT&CK ID form with base:id fallback
  • Override :id and :ids properties on risk:threat, entity:campaign, risk:tool:software, meta:technique, risk:mitigation, and plan:phase to use the new poly types
  • Add tests in test_model_infotech.py verifying MITRE IDs resolve to the correct forms

Test plan

  • Existing tests pass unchanged (test_model_risk, test_model_entity, test_model_planning)
  • New test_infotech_mitre assertions verify each MITRE ID form resolves correctly on its target form's :id property

🤖 Generated with Claude Code

Allow MITRE ATT&CK ID forms to be used on the :id properties of their
corresponding entity/risk forms by defining named poly types and
overriding the :id and :ids properties on each form.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mikemoritz
Copy link
Copy Markdown
Contributor Author

mikemoritz commented Apr 20, 2026

NOTE: This PR is a temporary solution to unblock power-up modeling. SYN-10572 was created to track the final solution.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (4866bbe) to head (89d8704).
⚠️ Report is 1 commits behind head on synapse-3xx.

Additional details and impacted files
@@             Coverage Diff              @@
##           synapse-3xx    #4904   +/-   ##
============================================
  Coverage        96.47%   96.48%           
============================================
  Files              259      259           
  Lines            63207    63207           
============================================
+ Hits             60981    60983    +2     
+ Misses            2226     2224    -2     
Flag Coverage Δ
linux 96.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mikemoritz and others added 2 commits April 20, 2026 17:27
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mikemoritz mikemoritz marked this pull request as ready for review April 20, 2026 18:16
@mikemoritz mikemoritz merged commit cc60ea9 into synapse-3xx Apr 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants