SYN-10634: Set service log key for AHA service#4952
Merged
Conversation
The AHA service does not register itself with AHA, so the cell logic that derives the 'service' log key from 'aha:name' + 'aha:network' yields nothing when 'aha:name' is not configured (the typical k8s deployment). Extract the derivation into Cell._getAhaSvcName() and override in AhaCell to default 'aha:name' to 'aha'.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4952 +/- ##
==========================================
- Coverage 97.78% 97.75% -0.04%
==========================================
Files 299 299
Lines 63351 63362 +11
==========================================
- Hits 61949 61940 -9
- Misses 1402 1422 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vEpiphyte
reviewed
May 18, 2026
Co-authored-by: vEpiphyte <epiphyte@vertex.link>
super() already binds self; passing self again caused a TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AhaCelldid not populate theservicelog key because the typical AHA deployment (perdocs/synapse/kubernetes/aha.yaml) setsaha:networkbut notaha:name, so theCell.__anit__block that derivesservicefrom both never fires.Cell._getAhaSvcName();AhaCell._getAhaSvcName()overrides to defaultaha:nameto'aha'so the key is always set.Test plan
python -m pytest synapse/tests/test_lib_aha.py(26 passed, includes newtest_lib_aha_logging)python -m pytest synapse/tests/test_lib_cell.py(60 passed, 3 skipped)Jira: https://vertexproject.atlassian.net/browse/SYN-10634