audit: PR #269 (signal auto-unwrap by nora) - Grade D

[vertz-tech-lead]

Audit Summary

PR #269 — Signal property auto-unwrap feature by nora (vertz-tech-lead)
Grade: D — Good code, broken process

Key Findings

✅ Code Quality: Excellent

• 411 lines of tests for 270 lines of implementation (1.52x ratio)
• Comprehensive edge cases, clean architecture
• Zero security issues

❌ Process Violations: Severe

• TDD (F): All 681 lines committed together, no red-green cycle
• Quality Gates (D): Lint not run before first commit
• Git Process (D): Worktree isolation not used, picked up unrelated audit files
• Design (F): No ticket or design doc exists for this feature

Critical Issues

1. TDD completely bypassed — all tests and implementation written and committed together
2. No ticket authorization — feature implemented without stakeholder approval or design doc
3. Worktree pollution repeated — PR claimed to fix worktree issues from PR feat(compiler): eliminate .value from public API — auto-unwrap signal properties #264 but made the same mistake

Recommendations

• TDD training session for nora
• Pre-commit hooks to enforce quality gates
• Mandatory ticket links in PR template

See full report: plans/audits/2026-02-14-pr269-nora.md
Structured data: plans/audits/data/2026-02-14-pr269-nora.json

[github-actions]

Coverage Report for Compiler (packages/compiler)

Status	Category	Percentage	Covered / Total
🔵	Lines	92.25%	1430 / 1550
🔵	Statements	90.07%	1524 / 1692
🔵	Functions	83.11%	256 / 308
🔵	Branches	83.37%	697 / 836

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Unchanged Files
packages/compiler/src/compiler.ts	100%	100%	100%	100%
packages/compiler/src/config.ts	100%	100%	100%	100%
packages/compiler/src/errors.ts	100%	100%	100%	100%
packages/compiler/src/incremental.ts	100%	88.37%	100%	100%
packages/compiler/src/typecheck.ts	93.47%	55.55%	88.88%	93.47%	86-87, 109
packages/compiler/src/__tests__/incremental.test-d.ts	0%	100%	0%	0%	11-48
packages/compiler/src/__tests__/ir-types.test-d.ts	0%	0%	0%	0%	15-114
packages/compiler/src/__tests__/codegen-poc/spike.ts	95.89%	81.25%	100%	95.77%	97, 132, 139, 152-155
packages/compiler/src/analyzers/app-analyzer.ts	92.85%	77.77%	100%	98.7%	116, 119, 132, 153, 180, 189
packages/compiler/src/analyzers/base-analyzer.ts	100%	100%	100%	100%
packages/compiler/src/analyzers/dependency-graph-analyzer.ts	97.26%	80.35%	92.3%	99.25%	25, 212, 251, 268
packages/compiler/src/analyzers/env-analyzer.ts	94.73%	87.5%	100%	100%	27
packages/compiler/src/analyzers/middleware-analyzer.ts	97.67%	94.44%	100%	97.61%	129
packages/compiler/src/analyzers/module-analyzer.ts	87.03%	65.38%	100%	100%	32, 84, 87, 91, 94, 97, 118
packages/compiler/src/analyzers/route-analyzer.ts	93.61%	86.53%	94.44%	97.6%	40, 53, 102, 108, 162, 181, 194, 301, 347
packages/compiler/src/analyzers/schema-analyzer.ts	86.56%	71.42%	100%	96.42%	20, 22, 23, 50, 55, 58, 67, 88, 118
packages/compiler/src/analyzers/service-analyzer.ts	85.71%	60%	90.9%	92.72%	20, 30, 59, 81, 95, 99, 102, 119, 132
packages/compiler/src/generators/base-generator.ts	100%	100%	100%	100%
packages/compiler/src/generators/boot-generator.ts	97.72%	87.5%	100%	100%	32
packages/compiler/src/generators/index.ts	100%	100%	100%	100%
packages/compiler/src/generators/manifest-generator.ts	97.43%	96.87%	100%	100%	72
packages/compiler/src/generators/openapi-generator.ts	94.54%	82.08%	93.75%	96.19%	143, 302, 330, 335, 340-342
packages/compiler/src/generators/route-table-generator.ts	97.22%	100%	85.71%	100%	93
packages/compiler/src/generators/schema-registry-generator.ts	100%	100%	100%	100%
packages/compiler/src/generators/__tests__/boot-generator.test-d.ts	0%	100%	0%	0%	5-21
packages/compiler/src/generators/__tests__/manifest-generator.test-d.ts	0%	100%	0%	0%	11-32
packages/compiler/src/generators/__tests__/route-table-generator.test-d.ts	0%	100%	0%	0%	5-12
packages/compiler/src/generators/__tests__/schema-registry-generator.test-d.ts	0%	100%	0%	0%	5-21
packages/compiler/src/ir/builder.ts	100%	100%	100%	100%
packages/compiler/src/ir/merge.ts	100%	100%	100%	100%
packages/compiler/src/ir/types.ts	100%	100%	100%	100%
packages/compiler/src/utils/ast-helpers.ts	100%	93.33%	100%	100%
packages/compiler/src/utils/import-resolver.ts	89.18%	76.92%	100%	93.75%	26, 39, 47, 77
packages/compiler/src/utils/schema-executor.ts	100%	83.33%	100%	100%
packages/compiler/src/validators/completeness-validator.ts	96.25%	89.28%	100%	99.32%	108, 129, 183, 208, 364, 403
packages/compiler/src/validators/index.ts	100%	100%	100%	100%
packages/compiler/src/validators/module-validator.ts	100%	100%	100%	100%
packages/compiler/src/validators/naming-validator.ts	95.34%	89.65%	100%	100%	62, 81
packages/compiler/src/validators/placement-validator.ts	100%	100%	100%	100%

Generated in workflow #566 for commit 41729bf by the Vitest Coverage Report Action

[github-actions]

Coverage Report for CLI (packages/cli)

Status	Category	Percentage	Covered / Total
🔵	Lines	94.05%	348 / 370
🔵	Statements	93.55%	363 / 388
🔵	Functions	87%	87 / 100
🔵	Branches	77.62%	170 / 219

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Unchanged Files
packages/cli/src/cli.ts	100%	100%	100%	100%
packages/cli/src/commands/build.ts	95.65%	85.71%	66.66%	100%	27
packages/cli/src/commands/check.ts	100%	100%	100%	100%
packages/cli/src/commands/codegen.ts	100%	84.61%	100%	100%
packages/cli/src/commands/deploy.ts	100%	100%	100%	100%
packages/cli/src/commands/generate.ts	100%	100%	100%	100%
packages/cli/src/commands/routes.ts	94.28%	71.42%	90.9%	92.85%	47, 57
packages/cli/src/config/defaults.ts	100%	100%	100%	100%
packages/cli/src/config/loader.ts	45.83%	15.38%	66.66%	45.83%	19-40, 58-68
packages/cli/src/deploy/detector.ts	100%	100%	100%	100%
packages/cli/src/deploy/dockerfile.ts	100%	100%	100%	100%
packages/cli/src/deploy/fly.ts	100%	100%	100%	100%
packages/cli/src/deploy/railway.ts	100%	100%	100%	100%
packages/cli/src/dev-server/dev-loop.ts	100%	100%	100%	100%
packages/cli/src/dev-server/process-manager.ts	91.42%	66.66%	92.3%	94.11%	45, 50-51
packages/cli/src/dev-server/watcher.ts	95.65%	87.5%	100%	100%	27
packages/cli/src/generators/module.ts	100%	100%	100%	100%
packages/cli/src/generators/naming.ts	100%	100%	100%	100%
packages/cli/src/generators/router.ts	100%	100%	100%	100%
packages/cli/src/generators/schema.ts	100%	100%	100%	100%
packages/cli/src/generators/service.ts	100%	100%	100%	100%
packages/cli/src/ui/diagnostic-formatter.ts	100%	76.31%	100%	100%
packages/cli/src/ui/task-runner.ts	55.55%	100%	25%	55.55%	39-48
packages/cli/src/ui/theme.ts	100%	100%	100%	100%
packages/cli/src/ui/components/Banner.tsx	100%	100%	100%	100%
packages/cli/src/ui/components/DiagnosticDisplay.tsx	100%	81.25%	100%	100%
packages/cli/src/ui/components/DiagnosticSummary.tsx	100%	100%	100%	100%
packages/cli/src/ui/components/Message.tsx	100%	100%	100%	100%
packages/cli/src/ui/components/SelectList.tsx	100%	100%	100%	100%
packages/cli/src/ui/components/Task.tsx	100%	100%	100%	100%
packages/cli/src/ui/components/TaskList.tsx	100%	100%	100%	100%
packages/cli/src/utils/format.ts	100%	91.66%	100%	100%
packages/cli/src/utils/paths.ts	100%	83.33%	100%	100%
packages/cli/src/utils/prompt.ts	100%	100%	100%	100%
packages/cli/src/utils/runtime-detect.ts	66.66%	75%	100%	66.66%	5

Generated in workflow #566 for commit 41729bf by the Vitest Coverage Report Action

[vertz-dev-dx]

Audit report, docs-only, LGTM