fix: FalkorDB data not persisting across restarts#99
Merged
jack-arturo merged 1 commit intoverygoodplugins:mainfrom Mar 2, 2026
Merged
fix: FalkorDB data not persisting across restarts#99jack-arturo merged 1 commit intoverygoodplugins:mainfrom
jack-arturo merged 1 commit intoverygoodplugins:mainfrom
Conversation
FalkorDB's entrypoint (run.sh) always appends --dir $FALKORDB_DATA_PATH after $REDIS_ARGS, so the --dir /data in REDIS_ARGS was silently overridden. Redis was writing to /var/lib/falkordb/data (ephemeral container storage) instead of /data (the Docker volume). This caused silent data loss on every container restart — FalkorDB would come back with memory_count=0 while Qdrant (which persists correctly) still had all vectors, requiring a manual recovery step each time. Fix: Remove --dir from REDIS_ARGS and set FALKORDB_DATA_PATH=/data so the entrypoint uses the volume-mounted path.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughA configuration change to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jack-arturo
added a commit
that referenced
this pull request
Mar 2, 2026
🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.0...v0.13.0) (2026-03-02) ### Features * **bench:** benchmark testing infrastructure for rapid iteration ([#97](#97)) ([80a6f93](80a6f93)) * **recall:** add min_score threshold and adaptive floor filtering ([#73](#73)) ([#101](#101)) ([8df3c08](8df3c08)) * **viewer:** add standalone graph-viewer runtime files ([5bcb6db](5bcb6db)) * **viewer:** consolidate stable core and split-ready compatibility ([#94](#94)) ([958da72](958da72)) * **viewer:** externalize visualizer with /viewer compatibility routes ([29bafcf](29bafcf)) * **viewer:** merge visualizer stable core branch ([96b27bf](96b27bf)) ### Bug Fixes * FalkorDB data not persisting across restarts ([3bbc834](3bbc834)) * FalkorDB data not persisting across restarts ([#99](#99)) ([8490d36](8490d36)) * **mcp-sse:** sync tool schemas for SSE/MCP parity ([#104](#104)) ([d99b86d](d99b86d)) ### Documentation * **bench:** add PR [#73](#73), [#80](#80), and [#87](#87) experiment results ([#103](#103)) ([8533fac](8533fac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FalkorDB's entrypoint script (
run.sh) always appends--dir $FALKORDB_DATA_PATHafter$REDIS_ARGS, so the--dir /datainREDIS_ARGSis silently overridden by the defaultFALKORDB_DATA_PATH=/var/lib/falkordb/data.This means Redis writes its RDB dumps and AOF files to
/var/lib/falkordb/data(ephemeral container filesystem) instead of/data(the Docker volume). On any container restart or recreate, all FalkorDB graph data is lost.The failure is silent — FalkorDB comes back healthy with
memory_count=0while Qdrant still has all vectors, making it look like a FalkorDB bug rather than a persistence misconfiguration.Fix
--dir /datafromREDIS_ARGS(it was being ignored anyway)FALKORDB_DATA_PATH=/dataso the entrypoint's own--dirflag points to the volume mountVerification
After this change:
redis-cli CONFIG GET dirreturns/data(the volume) instead of/var/lib/falkordb/dataBGSAVEwrites to the volume-mounted path