Skip to content

Conversation

@taichi-ishitani
Copy link
Contributor

@taichi-ishitani taichi-ishitani commented Oct 29, 2025

fix #2011

Currenlty, GenericSymbolPath#unaliased_path returns invalid path if a const imported from other package is used as a generca args.

For case of the example in the above issue, unaliased and mangled path for c_module::<B_PKG> should be __c_module____b_pkg____a_pkg__32_A but actual result is __c_module____b_pkg___A.

Due to this, wrong mangled path is used to resolve generic instnace.

To fix this, insert resolve_imported duaring resolving path to alias target.

@taichi-ishitani taichi-ishitani marked this pull request as draft October 29, 2025 04:31
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #2013 will not alter performance

Comparing taichi-ishitani:fix_panic_emitter (0122cec) with master (43351bb)1

Summary

✅ 3 untouched

Footnotes

  1. No successful run was found on master (af420bb) during the generation of this report, so 43351bb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@taichi-ishitani taichi-ishitani marked this pull request as ready for review October 29, 2025 05:13
@taichi-ishitani taichi-ishitani marked this pull request as draft October 29, 2025 15:33
@taichi-ishitani taichi-ishitani mentioned this pull request Oct 29, 2025
@taichi-ishitani taichi-ishitani marked this pull request as ready for review October 30, 2025 01:36
@dalance dalance merged commit 3397042 into veryl-lang:master Oct 30, 2025
14 checks passed
@taichi-ishitani taichi-ishitani deleted the fix_panic_emitter branch October 30, 2025 04:13
@dalance dalance added this to the v0.17.0 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic emitter

2 participants