Conversation
The component_containerclusters test was failing when receiving "No binding for URI" error messages instead of the expected "Could not find" or "Not Found" patterns. Added pattern matching for this third variant and refactored the conditional logic to use more idiomatic Ruby (unless with OR instead of if with negated AND).
Updates Maven plugin versions and compiler configuration to match the upstream Vespa parent POM, ensuring consistent build behavior across the project. Changes include: - Update maven-javadoc-plugin: 3.8.0 -> 3.12.0 - Update maven-dependency-plugin: 3.7.1 -> 3.8.1 - Update exec-maven-plugin: 3.4.0 -> 3.4.1 - Add ASM 9.9 dependency to compiler plugin - Add compiler args to suppress serial, try, and processing warnings - Disable deprecation warnings display - Remove deprecated optimize option
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the tests module parent POM build plugin configuration/versions and adjusts a container cluster system test to accept additional “not found” error variants and use correct Ruby regex matching logic.
Changes:
- Update
maven-compiler-pluginconfiguration (warnings/deprecation flags and-Xlintarguments) and bump several Maven plugin versions intests/pom.xml. - Add an ASM dependency to the compiler plugin configuration in
tests/pom.xml. - Fix and broaden the “cluster not found” assertions in
component_containerclusters.rbby usingunlesswith proper=~checks and accepting an additional error message variant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/pom.xml | Updates build plugin configuration/versions used by test app modules. |
| tests/container/component_containerclusters/component_containerclusters.rb | Corrects regex assertion logic and expands accepted error responses for missing handler bindings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arnej27959
dismissed
hmusum’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.