Allow to get width without stave

[rvilarl]

fixes #245

see stringsync/vexml#233

[ronyeh]

Will a keysignature object be formatted multiple times even though it doesn't have a stave? In that situation, we are returning multiple dummy Stave objects. Is it better if the format() method creates a new dummy Stave and then call this.setStave()?

Should we log some warning in that case? Otherwise the key signature is attached to a stave that the developer never created, and it's kind of a silent failure.

[rvilarl]

@ronyeh thanks! Now setStave is used with a dummy Stave and commented. I prefer the comment because it is legitimate to use format without Stave to figure out the width.

[ronyeh]

Is this code already run through eslint? I see some weird lack of spacing. Between params and also before the brace. Also I would just save the dummy stave to a local variable so that I don’t need to call getStave().

…

On Mon, Sep 23, 2024 at 10:59 PM Rodrigo Vilar ***@***.***> wrote: @rvilarl <https://github.com/rvilarl> requested your review on: #246 <#246> Allow to get width without stave. — Reply to this email directly, view it on GitHub <#246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB2MCKJFJEPNEGWHWPPO73ZYD5TDAVCNFSM6AAAAABOTMF6JWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGM3TKNBRGYYDGMA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[rvilarl]

You are right I normally eslint. I will change it this evening. I will also remove the call to getStave.

[rvilarl]

@ronyeh done