feat: add Glance metrics#38
Merged
Merged
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Mohammed Naser (mnaser)
approved these changes
Nov 27, 2025
Member
Mohammed Naser (mnaser)
left a comment
Mohammed Naser (mnaser)
left a comment
There was a problem hiding this comment.
LGTM! This PR follows all established patterns correctly:
- ✅ Logger initialization uses the standard
namespace/subsystem/collectorpattern - ✅ Test data matches the upstream openstack-exporter fixtures
- ✅ Metric naming follows
prometheus.BuildFQName()convention - ✅ Error handling properly emits
_upmetric as 0 on failure, 1 on success - ✅ Components properly split into separate files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.