Update nbd from 0.2.2 to 0.3.1 - accounting for API change. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API change is the handshake() function now takes a function which returns the Export object corresponding to the one requested. In this case only one export name is used as only the one file (or device) is exported. A key difference is checking the size of the disk won't be done until the first client connects now. The early check could be done it just meant it was duplicated.
Contributor
Author
|
I don't know what to do about the about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API change is the handshake() function now takes a function which returns the Export object corresponding to the one requested.
In this case only one export name is used as only the one file (or device) is exported.
A key difference is checking the size of the disk won't be done until the first client connects now. The early check could be done it just meant it would be duplicated.