RSDK-11347 RSDK-12236: Use Conan server to speed up Orbbec CI#56
Merged
RSDK-11347 RSDK-12236: Use Conan server to speed up Orbbec CI#56
Conversation
lia-viam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the artifacts from viamrobotics/viam-cpp-sdk#494 in orbbec CI builds. Compare total runtimes from the PR jobs for this build to the last build using the old approach:
https://github.com/viam-modules/orbbec/actions/runs/18598304657
Note that build steps are written manually rather than reusing the Makefiles and startup scripts. This introduces some duplication, but also shows the limitations of the Makefile/script approach and why we should move away from them. In particular, the Makefile imposes too many decisions (creating a venv even if one already exists, manually cloning and building the SDK, etc) in a way that is highly coupled and non-modular
Once this is merged a similar approach can be applied to the publish job as well