stopProvisioning: always flip provisioning flag, even on cleanup error#232
Merged
Conversation
A transient failure in stopProvisioningHotspot or stopProvisioningBluetooth would skip setProvisioning(false), leaving connState reporting "still provisioning" while resources were already torn down. The agent then could not re-enter or exit provisioning correctly until restart. The joined error is still returned to callers, which already log it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jmatth
approved these changes
May 1, 2026
ale7714
added a commit
that referenced
this pull request
May 2, 2026
Conflict in stopProvisioning (#232): main joined the bluetooth teardown into the same call and made the provisioning-flag flip unconditional. Kept the unconditional flip; dropped the bluetooth teardown call since this PR moves BLE lifecycle ownership to bleLoop, where stopProvisioningBluetooth is invoked separately.
EvanDorsky
pushed a commit
to EvanDorsky/viam-agent
that referenced
this pull request
May 6, 2026
viamrobotics#232) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient failure in stopProvisioningHotspot or stopProvisioningBluetooth would skip setProvisioning(false), leaving connState reporting "still provisioning" while resources were already torn down. The agent then could not re-enter or exit provisioning correctly until restart.
The joined error is still returned to callers, which already log it.
Follow up to an edge case I noticed while working on #230