APP-16234: add offline msi installer with Agent binary embedded#234
Conversation
|
we should build and upload the msi to gcp - do you want to do it in this pr or as a fast follow? |
How are we currently building and distributing the (online) |
|
@abe-winter would know more, but i suspect we don't have a process for it yet |
|
yup no yaml yet for msi. remaining work to normalize on msi:
|
aldenh-viam
changed the title
|
Worked great on my windows vm, way better install experience than before. |
aldenh-viam
force-pushed
the
push-qrrpwmqlkvyl
branch
3 times, most recently
from
e1e698b to
ff26db5
Compare
|
Given the compressed offline installer is only 9MB, should I just make these changes in |
|
ya lets do that |
aldenh-viam
force-pushed
the
push-qrrpwmqlkvyl
branch
from
ff26db5 to
3774500
Compare
|
where are we pushing the msi? |
| run: | | ||
| $ProgressPreference = 'SilentlyContinue' | ||
| Invoke-WebRequest ` | ||
| -Uri "https://storage.googleapis.com/packages.viam.com/apps/viam-agent/viam-agent-stable-windows-x86_64" ` |
There was a problem hiding this comment.
- this binary comes from workflow.yml in this repo -- in theory you can build them at the same time rather than downloading
- warning: if you run this download-based msi task as part of an agent release workflow, I think you will get the previous stable version for weird release flow reasons
- curl is available on this machine if you prefer
There was a problem hiding this comment.
ideally we should use the binary that we just built
aldenh-viam
force-pushed
the
push-qrrpwmqlkvyl
branch
from
4991936 to
8b4d44f
Compare
|
CI run sample: https://github.com/viamrobotics/agent/actions/runs/25498673196/job/74826372596 It would upload |
| - name: Upload MSI to GCS (Release) | ||
| if: github.event_name == 'release' | ||
| shell: bash | ||
| run: gsutil -h "Cache-Control:no-cache" cp viam-agent-*-windows-x86_64.msi gs://packages.viam.com/apps/viam-agent/ |
There was a problem hiding this comment.
can we also upload to viam-agent-stable-windows-x86_64.msi for stable releases? so we have a stable path to refer to as well
cheukt
left a comment
cheukt
left a comment
There was a problem hiding this comment.
looks good! just one more request
|
Something of note: this installer has two new options: Checking is "Recommended for production deployments" -- should we not recommend this until we're sure it's the superior option? Some modules, like the keystrokes one, probably require full Local System permissions. 
Should we not recommend changing the default install location? |
|
i'll defer to @abe-winter for this, but i agree with removing ya we should recommend not changing the default install location. |
|
33df0b8 How's this for warning text? @abe-winter , @cheukt , @ale7714 
|
|
new text lgtm |
|
Hey @aldenh-viam — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
aldenh-viam
force-pushed
the
push-qrrpwmqlkvyl
branch
2 times, most recently
from
3c6943a to
993a77b
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
aldenh-viam
force-pushed
the
push-qrrpwmqlkvyl
branch
2 times, most recently
from
48ce09f to
49bb81d
Compare
4 participants
viam-agent-stable-windows-x86_64.exetomsi\viam-agent-from-installer.exemake msimsi\bin\x64\Release\Package.msi(above instructions should be set up in CI)
I confirmed I'm able to install Agent on an offline machine using the installer. It writes the Viam directories, including:
and starts up viam-agent.
viam-agent-stable-windows-x86_64.exeis 28,194KB andPackage.msiis 9,060 KB: