Skip to content

[RSDK-9632] Add deprecation notice to DiscoverComponents in API Repo #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randhid merged 2 commits into from
Jan 24, 2025
Merged

[RSDK-9632] Add deprecation notice to DiscoverComponents in API Repo #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fffb680
deprecate discovery
randhid Jan 24, 2025
d970c00
Built new protos from fffb680
github-actions[bot] Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions proto/viam/robot/v1/robot.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ service RobotService {
}

// DiscoverComponents returns the list of discovered component configurations.
// This API is deprecated
rpc DiscoverComponents(DiscoverComponentsRequest) returns (DiscoverComponentsResponse) {
option (google.api.http) = {get: "/viam/api/v1/discovery/components"};
option deprecated = true;
}

rpc FrameSystemConfig(FrameSystemConfigRequest) returns (FrameSystemConfigResponse) {
Expand Down Expand Up @@ -237,14 +239,17 @@ message GetSessionsResponse {
}

// Discovery
// Discovery is deprecated

message DiscoveryQuery {
option deprecated = true;
string subtype = 1;
string model = 2;
google.protobuf.Struct extra = 99;
}

message Discovery {
option deprecated = true;
DiscoveryQuery query = 1;
google.protobuf.Struct results = 2;
}
Expand All @@ -263,10 +268,12 @@ message GetModelsFromModulesResponse {
}

message DiscoverComponentsRequest {
option deprecated = true;
repeated DiscoveryQuery queries = 1;
}

message DiscoverComponentsResponse {
option deprecated = true;
repeated Discovery discovery = 1;
}

Expand Down
Loading
Loading