Skip to content

Conversation

@cheukt
Copy link
Member

@cheukt cheukt commented Oct 21, 2025

checked go, python, ts sdk for compatibility issues and it was fine

@cheukt cheukt requested a review from ale7714 October 21, 2025 16:45
@github-actions github-actions bot added the safe to test committer is a member of this org label Oct 21, 2025
@cheukt cheukt requested a review from benjirewis October 21, 2025 21:53
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no SDK even employed this right? These were just fields at the API level that were never filled in by the RDK when sending to clients or examined by the RDK when receiving from clients?

@cheukt cheukt added the ready-for-protos add this when you want protos to compile on every commit label Oct 22, 2025
@cheukt
Copy link
Member Author

cheukt commented Oct 22, 2025

yep, it was never filled out by the rdk and no sdks ever used this

@cheukt cheukt added the allow breaking Allow breaking changes by bypassing the buf-breaking check label Oct 22, 2025
@cheukt cheukt removed the ready-for-protos add this when you want protos to compile on every commit label Oct 22, 2025
@cheukt cheukt merged commit 0e3309b into viamrobotics:main Oct 22, 2025
9 of 15 checks passed
@cheukt cheukt deleted the remove-remote-paths branch October 22, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow breaking Allow breaking changes by bypassing the buf-breaking check protos-compiled safe to test committer is a member of this org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants