APP-9843: Provide the current step name when listing build jobs #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellee1019
changed the title
michaellee1019
added
the
ready-for-protos
gmulz
reviewed
Oct 27, 2025
proto/viam/app/build/v1/build.proto
Outdated
| JobStatus status = 4; | ||
| google.protobuf.Timestamp start_time = 5; | ||
| optional google.protobuf.Timestamp end_time = 6; | ||
| string build_step = 7; |
Member
There was a problem hiding this comment.
is this going to break anything if it's not optional?
Member
Author
There was a problem hiding this comment.
Will change to optional, missed this. It will be optionally provided since only an in-progress build will have its step returned. Regardless, it wont break anything. The requiredness of a field is always backend controlled, even if not set as optional, protobuf itself doesn't do validation.
Things that do cause breaking changes: removing a field, changing the datatype of a field, accidentally using a field number that was previously defined (will cause serialization issues).
gmulz
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.