Skip to content

Conversation

@nathan-contino
Copy link
Contributor

Fixes some broken links, broken commands, spruces up appearances, and adds some helpful extra commands and section titles to the README.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Apr 23, 2025
@netlify
Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 406ecb2
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/680a427e36178e0008e372ad
😎 Deploy Preview https://deploy-preview-4247--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.


```sh
make serve-dev-draft
```console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] Why change all of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think of it kind of like our command-line styling in the docs, where we include a prompt character ($) to indicate an interactive snippet, but a full shell script (even a one-liner) doesn't include the prompt. It's a subtle piece of UX, and currently the GitHub markdown preview doesn't do anything special with it, but technically it could someday. And in the meantime, it's very very very slightly better for folks with screen readers, so I try to follow the convention when possible (and spread the word, now you've hopefully been infected by the console mind-virus).

To check locally for broken links, install [`htmltest`](https://github.com/wjdp/htmltest):

```console
brew install htmltest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! However, [opt] could mention this is for mac and/or point non-mac users in the right direction. Majority of employees are using macs but external contributors and a handful of Viam folks have other machines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very true. However, most of the rest of the docs don't cater to non-macOS users, and honestly when I used Linux for work I ironically found the brew formula registry (https://formulae.brew.sh/formula/htmltest in this case) one of the best ways to find install steps for Linux, because the pages are short, simple, and always link to the source code and project homepage.

Backlog addition: add info for Linux users throughout the README. I just wish GFM (github-flavored markdown) would add support for tabs, because lining up installation instructions for each platform sequentially is kind of a pain.

Copy link
Contributor

@JessamyT JessamyT Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Yeah this readme doesn't have to cater to Linux now, but I'm surprised you say the docs in general don't--most machines run on Linux (e.g. Pi)! Have you noticed specific places where we abandon Linux users?

nathan-contino and others added 2 commits April 24, 2025 09:27
Co-authored-by: Jessamy Taylor <75634662+JessamyT@users.noreply.github.com>
@nathan-contino nathan-contino merged commit 2dbdb16 into main Apr 25, 2025
13 checks passed
@nathan-contino nathan-contino deleted the readme-improvements-april-2025 branch April 25, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to build This pull request is marked safe to build from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants