Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented May 14, 2025

Automated documentation updates from Promptless. Source: https://viaminc.slack.com/archives/D08RX76JM71/p1747236721875399

To request further automatic revisions, create a new comment with @Promptless.

@netlify
Copy link

netlify bot commented May 14, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit f99f7b8
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/682b62c44854d40008d23aa9
😎 Deploy Preview https://deploy-preview-4297--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 48 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@viambot
Copy link
Member

viambot commented May 14, 2025

👋 Thanks for contributing! A reviewer will look at it on the next working day!

@npentrel npentrel changed the title docs: Add system log forwarding configuration DOCS-3844: Add system log forwarding configuration May 14, 2025
Comment on lines 182 to 184
{{< alert title="Note" color="note" >}}
System log forwarding requires journald to be available on the system. This feature is only supported on Linux systems.
{{< /alert >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< alert title="Note" color="note" >}}
System log forwarding requires journald to be available on the system. This feature is only supported on Linux systems.
{{< /alert >}}

@promptless
Copy link
Contributor Author

promptless bot commented May 14, 2025

I've added the requested changes in commit 46aa092

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ npentrel
❌ promptless[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@npentrel npentrel requested a review from Otterverse May 15, 2025 11:38
@npentrel
Copy link
Contributor

Hi @Otterverse, would you mind checking this? This is our first PR that is AI generated, but I have reviewed it, so just be aware. Thanks!

Copy link
Contributor

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one line I think could be clearer, otherwise good.


You can control which system logs are forwarded using the following syntax:

- `"all"`: Forward all system logs (except `viam-agent` logs, which are never forwarded)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would reword this exception to say something like "note: viam-agent and viam-server logs are sent directly to the cloud (and always visible), so cannot be added or removed here"

@npentrel npentrel requested a review from Otterverse May 19, 2025 09:41
@promptless
Copy link
Contributor Author

promptless bot commented May 19, 2025

I've added the requested changes in commit 16a3289

@npentrel npentrel force-pushed the docs-update-e905ab4a-cf5c-4129-aa89-c17b9585fe40-20250514-165021 branch from 16a3289 to f99f7b8 Compare May 19, 2025 16:56
@npentrel npentrel merged commit 4cc268c into main May 19, 2025
19 of 20 checks passed
@npentrel npentrel deleted the docs-update-e905ab4a-cf5c-4129-aa89-c17b9585fe40-20250514-165021 branch May 19, 2025 16:59
@github-actions
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants