Skip to content

Conversation

@JessamyT
Copy link
Contributor

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label May 16, 2025
@netlify
Copy link

netlify bot commented May 16, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 5566b59
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/682e1f9a52d79f000897cb63
😎 Deploy Preview https://deploy-preview-4314--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 48 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.


1. Switch to **JSON** mode.

1. Add the following template to your configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but there is an easier way. The module page in the registry lets you copy the filled in info for the unlisted module

You can look at this one: https://app.viam.com/module/naomi/hello-world

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That usage info should possibly not be at the bottom of the module's page I think btw. That might be worth giving as product feedback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. That's fantastic, and also yeah I never scrolled down there because it's not there on listed modules, so it didn't occur to me that this page would change when I changed the listed status. That's really nice though. I will give feedback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JessamyT and others added 3 commits May 19, 2025 11:40
@JessamyT JessamyT force-pushed the 3993unlistedmodule branch from b817218 to e5b7b33 Compare May 19, 2025 19:07
@JessamyT JessamyT requested a review from npentrel May 19, 2025 19:07
Copy link
Contributor

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

Co-authored-by: Naomi Pentrel <5212232+npentrel@users.noreply.github.com>
@JessamyT JessamyT merged commit b3c71ac into viamrobotics:main May 21, 2025
12 checks passed
@JessamyT JessamyT deleted the 3993unlistedmodule branch May 21, 2025 19:02
@github-actions
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to build This pull request is marked safe to build from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants