Skip to content

Conversation

@JessamyT
Copy link
Contributor

@JessamyT JessamyT commented Jun 2, 2025

No description provided.

@netlify
Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 923fa1a
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/684324a71ef839000875aef5
😎 Deploy Preview https://deploy-preview-4374--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jun 2, 2025
viam module update
```

{{% hiddencontent %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an FAQ/Troubleshooting section at the bottom would be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one feels enough like common sense that I didn't want to clutter the page with it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common sense maybe but I think easy to miss

- **Unlisted**: Any user inside or outside of your organization, with a direct link, can view and use the module.
Only organization members can edit the module.
Not listed in the registry.
Not listed in the registry for users outside of your organization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@JessamyT JessamyT requested a review from npentrel June 3, 2025 23:14
Copy link
Contributor

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you feel strongly, but I added a (fairly hefty) suggestion. Normally I wouldn't pile onto Naomi's existing review, but as she's out today, and you're blocked on this, I figured I'd chime in.

@JessamyT JessamyT merged commit d00c0d1 into viamrobotics:main Jun 6, 2025
12 checks passed
@JessamyT JessamyT deleted the 4046seemodule branch June 6, 2025 18:05
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to build This pull request is marked safe to build from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants