Skip to content

Manage data pipelines: reference clarity, overview links, CLI output examples#4904

Merged
shannonbradshaw merged 2 commits intoviamrobotics:new-docs-sitefrom
shannonbradshaw:content/data-pipelines
Apr 13, 2026
Merged

Manage data pipelines: reference clarity, overview links, CLI output examples#4904
shannonbradshaw merged 2 commits intoviamrobotics:new-docs-sitefrom
shannonbradshaw:content/data-pipelines

Conversation

@shannonbradshaw
Copy link
Copy Markdown
Collaborator

Summary

PR B from the Manage Data section review. Cleans up the data pipelines subsection based on reviewer feedback about ambiguous reference wording and missing CLI output examples.

`reference.md`

  • Pipeline configuration fields table: added an intro sentence explaining what the fields are ("the underlying fields on the pipeline resource, set by the CLI flags and SDK parameters") and added a CLI flag column so readers see the direct mapping. Reviewer was unsure whether the table was the JSON schema, the CLI flag set, or both.
  • Data source types: split into two tables. The primary table covers type, CLI value, and description. The SDK constants live in a secondary table since they were dominating the width. Fixed the confusing `(query only)` label on the Pipeline sink row to `not valid on create` and added a paragraph explaining that `pipeline_sink` is a query-time data source type, not a create-time one. Verified against `rdk/cli/datapipelines.go:328-342` — `--data-source-type` on `create` accepts only `standard` or `hotstorage`.
  • Run statuses table: added a CLI label column. Verified against `rdk/cli/datapipelines.go:19-25`, where the CLI translates the proto enum values to friendlier labels (`SCHEDULED`→`Scheduled`, `STARTED`→`Running`, `COMPLETED`→`Success`, `FAILED`→`Failed`). SDK users see the enums; CLI users see the labels.
  • Delete warning: promoted to a `color=caution` alert box and cross-linked to the delete section on the manage page.

`overview.md`

  • Linked the four "how pipelines work" list items to concrete references: the MQL aggregation item links to Examples and tips, the cron schedule item links to Cron schedule, and the data source item links to Data source types. Reviewer said the overview was too abstract to click without a concrete anchor.

`query-results.md`

  • Rewrote the intro to tie back to Create a pipeline and explain upfront that querying pipeline results requires the pipeline ID. Added the CLI lookup commands (`viam datapipelines list` / `describe`) inline so a reader who forgot the ID can get it without leaving the page.

`manage-pipelines.md`

  • `viam datapipelines list` example output: added. Verified against `rdk/cli/datapipelines.go:62-68`. Each pipeline is printed as `\t (ID: ) [Enabled|Disabled] [Data Source Type: ]`. Added a note that an empty output means the organization has no pipelines, which resolves the reviewer's "I ran the command and nothing showed up" confusion.
  • `viam datapipelines describe` example output: added. Verified against `rdk/cli/datapipelines.go:201-225`. Shows the multi-line ID/Name/Enabled/Schedule/MQL query/DataSourceType block plus the `Last run:` section, with the alternate "Has not run yet." case noted.
  • Run statuses table: added the CLI label column to match the reference page.
  • Delete warning: promoted to a caution alert box.

Test plan

  • Netlify deploy preview builds
  • Reference preview: CLI flag column is visible in the Pipeline configuration fields table, two-table layout for Data source types reads correctly, Run statuses show both the SDK enum and the CLI label
  • Overview preview: the three new inline links resolve to the correct anchors
  • Query results preview: intro reads naturally, CLI commands are copy-pasteable
  • Manage pipelines preview: list and describe example outputs render in `text` code blocks without wrapping strangely

🤖 Generated with Claude Code

…ples

- reference.md: add a CLI flag column to the Pipeline configuration
  fields table with an intro explaining the fields are set by the
  listed CLI flags and SDK parameters. Split the Data source types
  table so the primary table covers CLI usage and description, with
  SDK constants in a second table. Replace the confusing "(query only)"
  label with "not valid on create" and a paragraph explaining that
  pipeline_sink is a query-time data source type, not a create-time
  one. Add a CLI label column to the Run statuses table and note
  that SDK methods return the enum while the CLI prints the friendly
  label. Promote the "deleting a pipeline deletes the sink" warning
  to a caution alert and link to the manage page.
- overview.md: link the "how pipelines work" list items to examples
  and the cron schedule / data source types references so readers
  hit concrete content instead of abstract descriptions.
- query-results.md: expand the intro to reference Create a pipeline,
  explain that the pipeline ID is how you target the sink, and show
  the viam datapipelines list / describe lookup commands up front.
- manage-pipelines.md: add example output for `viam datapipelines
  list` and `viam datapipelines describe` (verified against
  rdk/cli/datapipelines.go:45-72 and 171-228). Note that an empty
  list output means no pipelines in the org, which is not an error.
  Add a CLI label column to the local Run statuses table and note
  the SDK-vs-CLI label difference. Promote the "deleting a pipeline"
  warning to a caution alert.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2026

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 75babe0
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/69d983a687f7a00007d6e5bd
😎 Deploy Preview https://deploy-preview-4904--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40 (🔴 down 6 from production)
Accessibility: 99 (🔴 down 1 from production)
Best Practices: 92 (no change from production)
SEO: 89 (🔴 down 3 from production)
PWA: 60 (🔴 down 10 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation-focused update to the Data Pipelines “Manage data pipelines” section to reduce ambiguity in references and make the CLI experience clearer via concrete output examples and cross-links.

Changes:

  • Clarifies pipeline configuration/reference tables by adding CLI flag mappings, splitting wide tables, and adding CLI labels for run statuses.
  • Adds concrete cross-links from the overview to relevant reference/examples sections.
  • Expands “query results” and “manage pipelines” pages with CLI commands and example outputs (list/describe), plus improved delete warnings.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
docs/data/pipelines/reference.md Adds CLI flag mappings to config fields; refactors data source/run status tables; upgrades delete warning to caution alert with link.
docs/data/pipelines/overview.md Adds direct links to examples and reference anchors for the “how pipelines work” bullets.
docs/data/pipelines/query-results.md Rewrites intro to emphasize pipeline ID and adds CLI commands to retrieve it, linking to manage page.
docs/data/pipelines/manage-pipelines.md Adds CLI example outputs for list/describe, adds run status CLI labels, and upgrades delete warning to a caution alert.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/data/pipelines/reference.md Outdated
| `schedule` | string | Yes | `--schedule` | Cron expression in UTC. Determines both when the pipeline runs and the query time window. See [Cron schedule](#cron-schedule). |
| `mql_binary` | array | Yes | `--mql` or `--mql-path` | MQL aggregation pipeline as an array of stage objects. See [Supported MQL operators](/data/reference/#supported-mql-operators). |
| `enable_backfill` | bool | Yes | `--enable-backfill` | Whether to process historical time windows. See [Backfill behavior](#backfill-behavior). |
| `data_source_type` | enum | No | `--data-source-type` | Data source to query. Default: `standard`. See [Data source types](#data-source-types). |
Comment thread docs/data/pipelines/reference.md Outdated
Comment on lines +47 to +51
| Type | CLI `--data-source-type` value | Description |
| ------------- | ------------------------------ | ------------------------------------------------------------------------------------------------- |
| Standard | `standard` | The raw `readings` collection containing all historical tabular data. Default for new pipelines. |
| Hot storage | `hotstorage` | The [hot data store](/data/hot-data-store/). A rolling window of recent data, with lower latency. |
| Pipeline sink | not valid on create | The output of another pipeline. Used when querying results, not when creating a pipeline. |
Comment thread docs/data/pipelines/manage-pipelines.md Outdated
Comment on lines +22 to +27
Example output (one line per pipeline, indented by a leading tab in the actual output):

```text
hourly-temp-avg (ID: 64f3a1b2c4d5e6f7a8b9c0d1) [Enabled] [Data Source Type: Standard]
daily-summary (ID: 64f3a1b2c4d5e6f7a8b9c0d2) [Disabled] [Data Source Type: Hot Storage]
```
- reference.md: mark data_source_type as Required=Yes to align with
  create-a-pipeline.md and with the CLI's actual behavior. Verified
  against rdk/cli/datapipelines.go:99 + 328-342, where
  dataSourceTypeToProto errors on empty string, making the flag
  effectively required even though the CLI definition does not set
  Required: true.
- reference.md: put the actual pipeline_sink value string in the Data
  source types table instead of "not valid on create", and move the
  create-time restriction into the description so the column contains
  values consistently.
- manage-pipelines.md: drop the "indented by a leading tab" prose from
  the list example output. The rendered example uses spaces and
  mentioning tabs here just confuses readers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@shannonbradshaw shannonbradshaw merged commit 39fcbd4 into viamrobotics:new-docs-site Apr 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants