Add GetWorldPose to data capture supported methods#5047
Open
shannonbradshaw wants to merge 3 commits into
Open
Add GetWorldPose to data capture supported methods#5047shannonbradshaw wants to merge 3 commits into
shannonbradshaw wants to merge 3 commits into
Conversation
rdk#5984 adds GetWorldPose data capture to all component types via the frame system. Update both capture method tables and add a note about the frame system requirement. https://claude.ai/code/session_018QMSJutLKxL4U23QgiCM37
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
viambot
added
the
safe to build
|
Hey @shannonbradshaw — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
1 similar comment
|
Hey @shannonbradshaw — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
katiepeters
reviewed
May 26, 2026
| | [Power sensor](/hardware/common-components/add-a-power-sensor/) | `Voltage`, `Current`, `Power`, `GetWorldPose`, `DoCommand` | | ||
| | [Servo](/hardware/common-components/add-a-servo/) | `Position`, `GetWorldPose`, `DoCommand` | | ||
| | [Switch](/hardware/common-components/add-a-switch/) | `GetWorldPose`, `DoCommand` | | ||
| | [Generic](/hardware/common-components/add-a-generic/) | `GetWorldPose`, `DoCommand` | |
Member
There was a problem hiding this comment.
Looks like we're missing audio in/out
Collaborator
Author
There was a problem hiding this comment.
Good catch — fixed in 1b6fc1e. Added audio input (GetAudio, GetWorldPose, DoCommand) and audio output (GetWorldPose only) rows to the table.
Generated by Claude Code
Collaborator
Author
There was a problem hiding this comment.
Hold tight, @katiepeters I want to check what Claude did here.
Collaborator
Author
There was a problem hiding this comment.
OK. @katiepeters please pick up your review.
Address review comment: audio_in supports GetAudio, DoCommand, GetWorldPose; audio_out supports GetWorldPose only. https://claude.ai/code/session_018QMSJutLKxL4U23QgiCM37
Katie's review flagged audio in/out as missing from the data capture tables. The prior commit added both to the capture-supported.md include but not to the parallel "Supported resources" table here. Add audio in, which has the distinctive GetAudio capture method. Audio out has no capturable method beyond GetWorldPose, which the table note already covers, so it is not listed as a separate row. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source changes
GetWorldPose) to all component typesGetWorldPosecapture method (merged earlier)Docs changes
static/include/data/capture-supported.md: AddedGetWorldPoseto every component row in the viam-server tab (arm, base, board, button, camera, encoder, gantry, gripper, input controller, motor, movement sensor, sensor, power sensor, servo, switch, generic). Service rows unchanged.docs/data/capture-sync/capture-and-sync-data.md: AddedGetWorldPoseto the "Supported resources" table for all component types. Updated the note below the table to mentionGetWorldPoseand its frame system requirement.docs/data/reference.md: Added a note explaining thatGetWorldPosecaptures world-coordinate position via the frame system and requires a configured frame and frame system.How I found these
app-6117e0f-getworldpose-capturewas deferred until rdk#5984 merged. rdk#5984 merged on 2026-05-10.capture-supportedfound the include indocs/data/reference.md.docs/data/capture-sync/capture-and-sync-data.md.Generated by daily docs change agent
Generated by Claude Code