Update configs from TypeScript SDK integration #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
commented
Apr 11, 2023
| 'no-unreachable-loop': 'error', | ||
| 'no-undef-init': 'error', | ||
| 'no-underscore-dangle': 'error', | ||
| 'no-underscore-dangle': ['error', { allow: ['__VERSION__'] }], |
Contributor
Author
There was a problem hiding this comment.
See viamrobotics/viam-typescript-sdk#52 for why __VERSION__ is added to the allow list
mcous
commented
Apr 11, 2023
| uses: JS-DevTools/npm-publish@1641d030cee266f093503c555ee9303ae7aede16 | ||
| with: | ||
| package: ${{ input.package }} | ||
| package: ${{ inputs.package }} |
|
|
||
| // Bundler compatibility | ||
| "jsx": "preserve", | ||
| "isolatedModules": true, |
Contributor
Author
There was a problem hiding this comment.
This setting is redundant with verbatimModuleSyntax below and shouldn't have been included in the first place. My bad!
| 'import/order': 'error', | ||
|
|
||
| // Extra SonarJS rules | ||
| 'sonarjs/cognitive-complexity': ['error', 20], |
Contributor
Author
There was a problem hiding this comment.
20 matches the current value of the vanilla eslint complexity setting in viamrobotics/app
DTCurrie
reviewed
Apr 11, 2023
micheal-parks
approved these changes
Apr 11, 2023
maximpertsov
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is collecting updates in reaction to integrating this config into viam-typescript-sdk. See viamrobotics/viam-typescript-sdk#52 for a little more context