Skip to content

RSDK-13879 - revert no-cert, fix mdns connection#180

Merged
stuqdog merged 2 commits into
viamrobotics:mainfrom
stuqdog:RSDK-13879-revert-no-cert
May 28, 2026
Merged

RSDK-13879 - revert no-cert, fix mdns connection#180
stuqdog merged 2 commits into
viamrobotics:mainfrom
stuqdog:RSDK-13879-revert-no-cert

Conversation

@stuqdog
Copy link
Copy Markdown
Member

@stuqdog stuqdog commented May 26, 2026

  • Reverts no-cert check now that our certs aren't leaf-only.
  • Creates more nuanced tiering of preference for URIs (prefer non-loopback local, then prefer loopback local, then prefer whatever)
  • Don't try to dial via webRTC when using mDNS, which will fail and lead to a fallback which doesn't work in the offline case.

Tested locally in offline and online cases, successfully connected via mDNS.

@stuqdog stuqdog requested a review from a team as a code owner May 26, 2026 16:04
@stuqdog stuqdog merged commit 7894d2e into viamrobotics:main May 28, 2026
4 checks passed
@stuqdog stuqdog deleted the RSDK-13879-revert-no-cert branch May 28, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants