RSDK-12650 - use rust-utils header #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
allisonschiang and
lia-viam
and removed request for
a team
Member
Author
|
cc @acmorrow |
lia-viam
approved these changes
Nov 20, 2025
acmorrow
approved these changes
Nov 21, 2025
Comment on lines
+43
to
+44
| viam_free_string(p); | ||
| viam_free_rust_runtime(rust_runtime); |
Member
There was a problem hiding this comment.
I think the next step along these lines is to introduce a rust_utils.hpp header, which wraps up the C API into nice C++ types. That though can probably live in the C++ SDK, since if you are using rust utils from C++ you are I'd say 99% of the time using the C++ SDK.
…K-12650-use-rust-utils-header
…tuqdog/cpp-sdk into RSDK-12650-use-rust-utils-header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.