Skip to content

Fix: clicking on frames in the Treeview causes reparenting due to Tweakpane behavior #667

Merged
micheal-parks merged 3 commits intomainfrom
parent-fix
May 8, 2026
Merged

Fix: clicking on frames in the Treeview causes reparenting due to Tweakpane behavior #667
micheal-parks merged 3 commits intomainfrom
parent-fix

Conversation

@micheal-parks
Copy link
Copy Markdown
Member

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: 274499d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-08 19:08 UTC

Comment on lines +37 to +38
// @ts-expect-error This is for debugging
globalThis.__threlte__ = threlte
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to keep this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for it. I don't see any danger, and it saves me adding it and un-adding it all the time

Comment thread src/lib/ecs/useWorld.ts
Comment on lines +12 to +17
// @ts-expect-error This is for debugging.
globalThis.__koota__ = {
world,
traits,
relations,
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this?

@micheal-parks micheal-parks merged commit dc5c94f into main May 8, 2026
14 checks passed
@micheal-parks micheal-parks deleted the parent-fix branch May 8, 2026 19:08
@claude claude Bot mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants