Skip to content

Update Treeview to use entity relations#675

Merged
micheal-parks merged 4 commits into
mainfrom
treeview-entities
May 14, 2026
Merged

Update Treeview to use entity relations#675
micheal-parks merged 4 commits into
mainfrom
treeview-entities

Conversation

@micheal-parks
Copy link
Copy Markdown
Member

This PR removes a lot of custom tree building behavior in favor of just walking the new Koota relations among entities.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

⚠️ No Changeset found

Latest commit: 3aee032

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const { rootNodes, nodeMap } = $derived.by(() => {
// This ensures the tree rebuilds when frame parent relationships change
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
frames.current
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes the dependency of frames for rebuilding the tree. Tree rebuilds should now be exactly based on entity changes. More performant + fewer edge case bugs.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijayvuyyuru FYI since you encountered this bug

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-14 15:18 UTC

@micheal-parks micheal-parks merged commit dd4fd29 into main May 14, 2026
11 checks passed
@micheal-parks micheal-parks deleted the treeview-entities branch May 14, 2026 15:18
@claude claude Bot mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants