App 16362 update snapshot api to v2 style inputs returns#801
Conversation
🦋 Changeset detectedLatest commit: d1cad73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Make sure UUID and colors are used consistently
|
code Looks good! just confirm the dotColors is not a regression by making sure the main would generate the same snapshot and can you run these e2e tests to sanity check https://github.com/viamrobotics/visualization/blob/main/e2e/snapshot.test.ts |
| "lineWidth": 8, | ||
| "dotSize": 10, | ||
| "dotColors": "AACL" | ||
| "dotColors": "/6UA" |
There was a problem hiding this comment.
why is this different now?
| Base64 | Hex Bytes | RGB | Color |
|---|---|---|---|
AACL |
00 00 8B |
(0, 0, 139) |
Dark Blue |
/6UA |
FF A5 00 |
(255, 165, 0) |
Orange |
There was a problem hiding this comment.
Yep! Found the bug. Updated e2e tests by running in main, brought the new standard screenshots into this branch, ran again with fixes, and all tests pass as normal, with color reverted.
Updated snapshot e2e test screenshots from main, reran with all 9 passing. Color reverted as expected.
Changes
Tests:
Links
Docs: