Instance render all spheres#807
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ae40efd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Micheal Parks (micheal-parks)
changed the title
| const colorUtil = new Color() | ||
|
|
||
| /** Same resolution order as `Boxes.svelte` / `Frame.svelte`. */ | ||
| const resolveColor = (entity: Entity): Color => { |
Member
Author
There was a problem hiding this comment.
Since the shape of all the instanced rendering components is similar, I'll be merging this stuff together into shared helpers in the next PR
Micheal Parks (micheal-parks)
requested review from
Devin T. Currie (DTCurrie),
Matthew MacFarquhar (mattmacf98) and
Marcus (sucrammal)
Contributor
|
Matthew MacFarquhar (mattmacf98)
approved these changes
Jul 2, 2026
Devin T. Currie (DTCurrie)
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We know the deal by now. In one of Brandon's more complex examples, this halfs the number of draw calls from 300 -> 150. Big win in some scenes.