Fix pointcloud object positions#817
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 63e7159 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Micheal Parks (micheal-parks)
requested review from
Devin T. Currie (DTCurrie),
Matthew MacFarquhar (mattmacf98) and
Marcus (sucrammal)
…cs/acdc into pointcloud-object-fix
Contributor
|
Matthew MacFarquhar (mattmacf98)
approved these changes
Jul 6, 2026
Matthew MacFarquhar (mattmacf98)
left a comment
Matthew MacFarquhar (mattmacf98)
left a comment
Member
There was a problem hiding this comment.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
At some point in the instanced rendering PR stack, I missed pointcloud objects, causing them to not be displayed in the correct location currently. This PR simply brings them up to speed with exactly how geometries are assembled in
useGeometries, fixing any transform issues.